Allow filtering of combined coverage reports #4673
Conversation
Add a new `--only-label` option to `merge-coverage-reports` to include only one category of highlighting in the output. For example, merging coverage reports from test generation and verification using the option `--only-label NotCovered` will highlight only the regions not covered by either testing or verification.
| if ((onlyLabel ?? span.Label) == span.Label) { | ||
| mergedReport.LabelCode(span.Span, span.Label); | ||
| } |
There was a problem hiding this comment.
Is the intent here to display locations where both reports have the same label (i.e. intersection)? If yes, then there should be an else branch here that labels the code with the NotApplicable label. The report merged using the present approach will display the union between the two original reports.
There was a problem hiding this comment.
Not quite. The point is to highlight only the locations that, after merging (with union semantics), have the label specified on the command line. The expected output I've checked in looks the way I'd expect it to. The key use case I want to support is for NotCovered: highlight all locations that are not covered by either verification or tests.
There was a problem hiding this comment.
Alternatively, you could see this code as taking the merged report and removing all highlighting that isn't in the specified category. The conditional is arguably a bit confusing, given that it both checks whether the option has been specified and whether the current label matches the requested label in one expression.
There was a problem hiding this comment.
Ah, I see! So you can get the intersection if you don't use --only-label and the union if you do. This makes sense!
Add a new
--only-labeloption tomerge-coverage-reportsto include only one category of highlighting in the output. For example, merging coverage reports from test generation and verification using the option--only-label NotCoveredwill highlight only the regions not covered by either testing or verification.Description
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.