Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Generation] Reduce memory footprint by reusing the same Boogie program for multiple test generation queries #4530

Merged
merged 10 commits into from
Sep 16, 2023

Conversation

Dargones
Copy link
Collaborator

In draft stage because boogie-org/boogie/pull/780 should be merged first.

This PR reduces the memory footprint / running time of test generation by reusing the same in-memory representation of a Boogie program. Previously, Dafny would have to copy the entire Boogie program to a string and parse/resolve/typecheck it again for every new test Dafny generates. With some minor changes to Boogie, this deep-copy procedure is no longer necessary in Block and InlinedBlock modes (but still necessary for Path-based test generation - this is something I will have to work next)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@atomb
Copy link
Member

atomb commented Sep 12, 2023

I think this looks good. I'll give it a full review once boogie-org/boogie#780 is merged and released, since this PR will have to be updated to take advantage of that release.

@Dargones
Copy link
Collaborator Author

Thank you, Aaron! Could you create a new Boogie release, so that I can update this PR?

@atomb
Copy link
Member

atomb commented Sep 13, 2023

I'll put the release out as soon as boogie-org/boogie#783 is merged to bump the version number.

@Dargones Dargones marked this pull request as ready for review September 14, 2023 18:46
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think it's ready to merge once that reference manual build issue is resolved.

@atomb atomb enabled auto-merge (squash) September 15, 2023 17:57
@atomb atomb disabled auto-merge September 15, 2023 17:57
@atomb atomb enabled auto-merge (squash) September 15, 2023 17:58
@atomb atomb merged commit 04e2007 into dafny-lang:master Sep 16, 2023
18 checks passed
TaBo2410 added a commit that referenced this pull request Sep 20, 2023
…iment-trsplitexpr

* commit '86840e6b14386c1e88480854dd8ce64ad17cb2ff':
  Map eq range (#4567)
  Fix: Declarations with {:only} ensure that other declarations aren't displayed as verified in the gutter icons (#4433)
  Fix caching of export declarations (#4556)
  Do not return exceptions when doing hover in a program with parse errors (#4557)
  Proof dependency warnings (#4542)
  [Test Generation] Reduce memory footprint by reusing the same Boogie program for multiple test generation queries (#4530)
  Fix a variety of bugs in Rust backend based on ESDK testing (#4538)
  Checker for .Values and .Items on maps (#4551)
  feat: Allow more assumptions in library backend (#4545)
  feat: Attributes on reads clauses (#4554)
  Fix gutter icons fields (#4549)
  Report errors that occur in the project file, in the IDE as well (#4539)
  Switch to ubuntu-20.04 for the refman build (#4555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants