Diagnostic related fixes #4513
Merged
Diagnostic related fixes #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Sep 5, 2023
Comment on lines
+99
to
+101
| // var parseDiagnostics = await diagnosticsReceiver.AwaitNextDiagnosticsAsync(CancellationToken); | ||
| // Assert.Single(parseDiagnostics); | ||
| // Assert.Contains(parseDiagnostics, d => d.Message.Contains("cycle of includes")); |
There was a problem hiding this comment.
Relates to the skipped test. I was hoping that with the comment it would be OK to keep. Might help reduce confusion if we ever change the behavior and then this test breaks, but gets fixed with the commented code.
| @@ -21,6 +21,70 @@ namespace Microsoft.Dafny.LanguageServer.IntegrationTest.Synchronization { | |||
| public class DiagnosticsTest : ClientBasedLanguageServerTest { | |||
| private readonly string testFilesDirectory = Path.Combine(Directory.GetCurrentDirectory(), "Synchronization/TestFiles"); | |||
|
|
|||
| [Fact(Skip = "Not implemented. Requires separating diagnostics from different sources")] | |||
There was a problem hiding this comment.
Is this a test you intend to fix later?
There was a problem hiding this comment.
Allowing this test to pass would be an improvement, but I don't think it's something we need to do soon. Do you want me to remove it? To me it's a bit like a GH issue but then in the code, a reminder of something we can improve.
MikaelMayer
reviewed
Sep 6, 2023
| @@ -10,6 +10,7 @@ namespace XUnitExtensions.Lit { | |||
| /// because 'diff' does not exist on Windows. | |||
| /// </summary> | |||
| public class DiffCommand : ILitCommand { | |||
| private static readonly bool UpdateExpectFile = false; | |||
There was a problem hiding this comment.
Can you please document how to use this in the README of the tests? I'm interested but will soon forget where I had to change something.
…ummer/dafny into migratedResolutionDiagnostics
MikaelMayer
approved these changes
Sep 7, 2023
keyboardDrummer
added a commit
to keyboardDrummer/dafny
that referenced
this pull request
Sep 15, 2023
### Changes - Let rewriters that operate within the module caching context, use the correct `ErrorReporter`, so any diagnostics recorded by them are saved in the cache. - Use previous resolution diagnostics when processed parsed document and no parsing diagnostics were found, to prevent diagnostic flickering and reduce bandwidth used by diagnostics. ### Testing - Added two units tests for the above two issues <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 15, 2023
### Changes - Let rewriters that operate within the module caching context, use the correct `ErrorReporter`, so any diagnostics recorded by them are saved in the cache. - Use previous resolution diagnostics when processed parsed document and no parsing diagnostics were found, to prevent diagnostic flickering and reduce bandwidth used by diagnostics. ### Testing - Added two units tests for the above two issues <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
### Changes - Let rewriters that operate within the module caching context, use the correct `ErrorReporter`, so any diagnostics recorded by them are saved in the cache. - Use previous resolution diagnostics when processed parsed document and no parsing diagnostics were found, to prevent diagnostic flickering and reduce bandwidth used by diagnostics. ### Testing - Added two units tests for the above two issues <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
- Let rewriters that operate within the module caching context, use the correct `ErrorReporter`, so any diagnostics recorded by them are saved in the cache. - Use previous resolution diagnostics when processed parsed document and no parsing diagnostics were found, to prevent diagnostic flickering and reduce bandwidth used by diagnostics. - Added two units tests for the above two issues <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ErrorReporter, so any diagnostics recorded by them are saved in the cache.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.