-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to run Boogie with the args Dafny uses #4492
Open
atomb
wants to merge
14
commits into
dafny-lang:master
Choose a base branch
from
atomb:boogie-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
363efe3
Add script to run Boogie with the args Dafny uses
atomb 595a779
Fix dotnet tool boogie version
atomb 708035a
Merge branch 'master' into boogie-script
atomb 4673b2a
Try to fix typo
atomb 2cf5cae
Set working directory
atomb 9881e38
Use a shell script instead
atomb 5ffb627
Merge branch 'master' into boogie-script
atomb 05b00e2
Merge remote-tracking branch 'upstream/master' into boogie-script
atomb 2fb6f87
Move prover path out of Boogie args config file
atomb 035767a
Fix mistaken edit
atomb 08520f8
Merge branch 'master' into boogie-script
atomb 46c9355
Merge remote-tracking branch 'upstream/master' into boogie-script
atomb 575e8f1
Move boogie-args.cfg
atomb f986ba0
Minor cleanup
atomb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move prover path out of Boogie args config file
- Loading branch information
commit 2fb6f876277352f6908bd188d6592f64579a3cdf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this deserves to be under
Source
somewhere rather than hidden underTest
, since it's an alternate expression of how Dafny configures Boogie.On that note, is there any way to assert that these are equivalent to what options Dafny actually sets through the library interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to be able to guarantee that they're equivalent. I haven't thought of a good way to do it yet, but that doesn't mean there isn't one!
Until there is one, it feels weird to put it under
Source
when nothing in that directory uses it, but stuff inTest
does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fix issue 2800, or would a slight addition to this PR fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still some more work we'd need to do to ensure that's correct. We could add some code to copy the contents of this new file to the top of the generated Boogie file, but there's currently no guarantee that that would match what Dafny uses.