Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symbol name as range for timeout diagnostic #4477

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Use symbol name as range for timeout diagnostic #4477

merged 4 commits into from
Aug 28, 2023

Conversation

keyboardDrummer
Copy link
Member

Changes

  • Instead of red underlining the whole function/method, only underline the name, when a timeout occurs

Testing

  • Added test for the above

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) August 25, 2023 10:54
atomb
atomb approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement!

@keyboardDrummer keyboardDrummer merged commit 3c1066a into dafny-lang:master Aug 28, 2023
18 checks passed
@keyboardDrummer keyboardDrummer deleted the betterTimeoutDiagnostic branch August 28, 2023 21:43
keyboardDrummer added a commit to keyboardDrummer/dafny that referenced this pull request Sep 15, 2023
@keyboardDrummer
Use symbol name as range for timeout diagnostic (dafny-lang#4477)
6a235e6 
### Changes
- Instead of red underlining the whole function/method, only underline
the name, when a timeout occurs

### Testing
- Added test for the above

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer added a commit that referenced this pull request Sep 19, 2023
@keyboardDrummer
Use symbol name as range for timeout diagnostic (#4477)
6df7ebc 
### Changes
- Instead of red underlining the whole function/method, only underline
the name, when a timeout occurs

### Testing
- Added test for the above

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
@BrewTestBot BrewTestBot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

@MikaelMayer MikaelMayer Awaiting requested review from MikaelMayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keyboardDrummer @atomb