[Counterexamples] Fix stack overflow during counterexample extraction for some programs #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2023 14:33
atomb
approved these changes
Aug 8, 2023
keyboardDrummer
pushed a commit
to keyboardDrummer/dafny
that referenced
this pull request
Sep 15, 2023
… for some programs (dafny-lang#4392) Fixes dafny-lang#4391 This PR fixes a potential case of an infinite recursion in Dafny counterexample extraction (exemplified by the added test). The solution is to change the order in which Dafny looks at functions in the counterexample model when trying to deduce the type of a variable. By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license. --------- Co-authored-by: Aleksandr Fedchin <[email protected]>
keyboardDrummer
pushed a commit
that referenced
this pull request
Sep 19, 2023
… for some programs (#4392) Fixes #4391 This PR fixes a potential case of an infinite recursion in Dafny counterexample extraction (exemplified by the added test). The solution is to change the order in which Dafny looks at functions in the counterexample model when trying to deduce the type of a variable. By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license. --------- Co-authored-by: Aleksandr Fedchin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4391
This PR fixes a potential case of an infinite recursion in Dafny counterexample extraction (exemplified by the added test). The solution is to change the order in which Dafny looks at functions in the counterexample model when trying to deduce the type of a variable.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.