Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z3 download #4381

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix z3 download #4381

merged 2 commits into from
Aug 3, 2023

Conversation

atomb
Copy link
Member

@atomb atomb commented Aug 3, 2023

Fixes the download URLs for Z3 in a couple of places.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@atomb atomb added the run-deep-tests Tells CI to run all tests label Aug 3, 2023
@atomb atomb enabled auto-merge (squash) August 3, 2023 18:33
Copy link
Collaborator

@fabiomadge fabiomadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still package the same z3 binaries we download with the Makefile?

@atomb
Copy link
Member Author

atomb commented Aug 3, 2023

Do we still package the same z3 binaries we download with the Makefile?

If I understand you correctly, yes. The binaries downloaded by the Makefile and the GitHub workflows are all binaries we build and package. And we still build and package 4.8.5, though we could probably stop doing that soon.

@fabiomadge
Copy link
Collaborator

Yes, I just had a look at package.py myself. It contains code that implements the fallback to x86.

@atomb atomb merged commit 656a114 into dafny-lang:master Aug 3, 2023
29 of 33 checks passed
@atomb atomb self-assigned this Aug 28, 2023
keyboardDrummer pushed a commit to keyboardDrummer/dafny that referenced this pull request Sep 15, 2023
Fixes the download URLs for Z3 in a couple of places.

By submitting this pull request, I confirm that my contribution
is made under the terms of the MIT license.
keyboardDrummer pushed a commit that referenced this pull request Sep 19, 2023
Fixes the download URLs for Z3 in a couple of places.

By submitting this pull request, I confirm that my contribution
is made under the terms of the MIT license.
@atomb atomb deleted the fix-z3-download branch January 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-deep-tests Tells CI to run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants