Feat: Default function opacity setting + autoreveal option #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes # <!-- Is this a user-visible change? Remember to update RELEASE_NOTES.md --> <!-- Is this a bug fix? Remember to include a test in Test/git-issues/ --> <!-- Is this a bug fix for an issue introduced in the latest release? Mention this in the PR details and ensure a patch release is considered --> <!-- Does this PR need tests? Add them to `Test/` or to `Source/*.Test/…` and run them with `dotnet test` --> <!-- Are you moving a large amount of code? Read CONTRIBUTING.md to learn how to do that while maintaining git history --> <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small> --------- Co-authored-by: Mikaël Mayer <[email protected]> Co-authored-by: Remy Willems <[email protected]> Co-authored-by: David Cok <[email protected]> Co-authored-by: davidcok <[email protected]>
…-as-arguments-causes-type' into all-opaque # Conflicts: # Source/DafnyCore/AST/Modules/ModuleDefinition.cs
…-opaque-function-causes' into all-opaque # Conflicts: # Source/DafnyCore/Verifier/Translator.cs # Test/git-issues/git-issue-4202.dfy # Test/git-issues/git-issue-4202.dfy.expect
# Conflicts: # Source/DafnyCore/Resolver/Rewriters.cs
…' into all-opaque
…' into all-opaque
…eals in a requires stmt, etc
…emmas. Implemented proper graph traversal for reveal stmt name building.
MikaelMayer
reviewed
Aug 29, 2023
…ewriter; added support for datatype constructor default values.
MikaelMayer
previously approved these changes
Aug 29, 2023
# Conflicts: # Source/DafnyCore/AST/Members/Method.cs # docs/DafnyRef/Attributes.md
EkanshdeepGupta
dismissed stale reviews from atomb and MikaelMayer
via
dc24bb8
MikaelMayer
approved these changes
Aug 30, 2023
keyboardDrummer
added a commit
to keyboardDrummer/dafny
that referenced
this pull request
Sep 15, 2023
…g#4342) This PR adds an additional cmdline flag `--default-function-opacity` which controls the default opacity of functions from `transparent`, `autoRevealDependencies`, or `opaque`. `transparent` is synonymous with the present behavior. `autoRevealDependencies` is a mode which makes functions opaque by default and inserts reveal stmts in each callable for each function dependency. `opaque` is a mode which makes functions opaque by default, leaving the user to insert all required function dependencies. <!-- Is this a user-visible change? Remember to update RELEASE_NOTES.md --> <!-- Is this a bug fix? Remember to include a test in Test/git-issues/ --> <!-- Is this a bug fix for an issue introduced in the latest release? Mention this in the PR details and ensure a patch release is considered --> <!-- Does this PR need tests? Add them to `Test/` or to `Source/*.Test/…` and run them with `dotnet test` --> <!-- Are you moving a large amount of code? Read CONTRIBUTING.md to learn how to do that while maintaining git history --> <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small> --------- Co-authored-by: Mikaël Mayer <[email protected]> Co-authored-by: Remy Willems <[email protected]> Co-authored-by: David Cok <[email protected]> Co-authored-by: davidcok <[email protected]> Co-authored-by: Mikael Mayer <[email protected]> Co-authored-by: Aaron Tomb <[email protected]>
This was referenced Sep 18, 2023
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
This PR adds an additional cmdline flag `--default-function-opacity` which controls the default opacity of functions from `transparent`, `autoRevealDependencies`, or `opaque`. `transparent` is synonymous with the present behavior. `autoRevealDependencies` is a mode which makes functions opaque by default and inserts reveal stmts in each callable for each function dependency. `opaque` is a mode which makes functions opaque by default, leaving the user to insert all required function dependencies. <!-- Is this a user-visible change? Remember to update RELEASE_NOTES.md --> <!-- Is this a bug fix? Remember to include a test in Test/git-issues/ --> <!-- Is this a bug fix for an issue introduced in the latest release? Mention this in the PR details and ensure a patch release is considered --> <!-- Does this PR need tests? Add them to `Test/` or to `Source/*.Test/…` and run them with `dotnet test` --> <!-- Are you moving a large amount of code? Read CONTRIBUTING.md to learn how to do that while maintaining git history --> <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small> --------- Co-authored-by: Mikaël Mayer <[email protected]> Co-authored-by: Remy Willems <[email protected]> Co-authored-by: David Cok <[email protected]> Co-authored-by: davidcok <[email protected]> Co-authored-by: Mikael Mayer <[email protected]> Co-authored-by: Aaron Tomb <[email protected]>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
This PR adds an additional cmdline flag `--default-function-opacity` which controls the default opacity of functions from `transparent`, `autoRevealDependencies`, or `opaque`. `transparent` is synonymous with the present behavior. `autoRevealDependencies` is a mode which makes functions opaque by default and inserts reveal stmts in each callable for each function dependency. `opaque` is a mode which makes functions opaque by default, leaving the user to insert all required function dependencies. <!-- Is this a user-visible change? Remember to update RELEASE_NOTES.md --> <!-- Is this a bug fix? Remember to include a test in Test/git-issues/ --> <!-- Is this a bug fix for an issue introduced in the latest release? Mention this in the PR details and ensure a patch release is considered --> <!-- Does this PR need tests? Add them to `Test/` or to `Source/*.Test/…` and run them with `dotnet test` --> <!-- Are you moving a large amount of code? Read CONTRIBUTING.md to learn how to do that while maintaining git history --> <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small> --------- Co-authored-by: Mikaël Mayer <[email protected]> Co-authored-by: Remy Willems <[email protected]> Co-authored-by: David Cok <[email protected]> Co-authored-by: davidcok <[email protected]> Co-authored-by: Mikael Mayer <[email protected]> Co-authored-by: Aaron Tomb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional cmdline flag
--default-function-opacitywhich controls the default opacity of functions fromtransparent,autoRevealDependencies, oropaque.transparentis synonymous with the present behavior.autoRevealDependenciesis a mode which makes functions opaque by default and inserts reveal stmts in each callable for each function dependency.opaqueis a mode which makes functions opaque by default, leaving the user to insert all required function dependencies.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.