Fix: Removed wrong "related position" precision when dealing with regrouped quantifiers #4187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2211
After investigation it looks like the following expression
was split in two while searching for triggers
But another pass for searching for triggers regroups quantifiers which have the same bound variables and same triggers. Since the two expressions have the same trigger s[i], they are regroupped with an AND back to:
As you can see, the problem of the regrouping is that it takes the token of the first element of the group, which had an indication that it pointed to P1.
The last related location of #2211 thus was an artefact of the token being copied without paying attention to that detail. Since we regroup the tokens, there is no nested token there to have so this PR removes nested tokens when regrouping comprehensions to avoid giving false information.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.