Adding errorids for refinement errors #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-aws
requested changes
May 30, 2023
docs/HowToFAQ/Errors-Refinement.md
Outdated
|
|
||
| The declarations in a refining module must have the same type as in the base module. In fact, to enable easier checking that the type | ||
| has not changed, the type must be expressed in the same syntactic form in the two declarations. It is not permitted to use a type in one place and | ||
| an equivalent type synonym in the other. |
There was a problem hiding this comment.
Suggested change
| an equivalent type synonym in the other. | |
| an equivalent type synonym in another. |
docs/HowToFAQ/Errors-Refinement.md
Outdated
| ``` | ||
|
|
||
| A refined declaration of a `const` may add an initializer, but it cannot replace an initializer declared in the base, | ||
| even if it is syntactically the same value. |
There was a problem hiding this comment.
Use an example that "is syntactically the same value"?
stefan-aws
requested changes
May 30, 2023
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
Co-authored-by: Stefan Zetzsche <[email protected]>
stefan-aws
reviewed
May 30, 2023
stefan-aws
previously approved these changes
May 30, 2023
Co-authored-by: Stefan Zetzsche <[email protected]>
stefan-aws
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.