Remove verify and compile fields from modules to enable caching parsing #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2023
alex-chew
reviewed
May 23, 2023
alex-chew
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Modules no longer contain properties that indicate whether they should be verified and/or compiled, which is required for the upcoming change to cache parsing.
The API of Parser is simplified, so it always takes a TextReader as input.
Change
SourceProcessorso it doesn't need to open a file separately to determine what newlines it has, but can instead ride on the existing TextReader that is also used for parsing the file.Testing
The above is purely refactoring, so no test changes have been made.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.