Remove IncludeToken as prep for caching parsing #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
May 4, 2023
Source/DafnyLanguageServer/Workspace/Notifications/VerificationDiagnosticsParams.cs
Show resolved
Hide resolved
Co-authored-by: Mikaël Mayer <[email protected]>
… into removeIncludeToken
… into removeIncludeToken
MikaelMayer
requested changes
May 5, 2023
MikaelMayer
approved these changes
May 8, 2023
fabiomadge
added a commit
to fabiomadge/dafny
that referenced
this pull request
May 9, 2023
)" This reverts commit eb45d23.
fabiomadge
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a file that's included is parsed differently. Its tokens are wrapped in an
IncludeToken, that includes a reference to the including file.To allow reusing parsed files in a cache, how the file is parsed should be independent of what triggered it to be parsed. To achieve that, this PR removes
IncludeToken. To enable still determining whether a particular token was part of an include or not, tokens now store aUrithat uniquely identifies the document that token came from. The Uris of the root documents are stored inDefaultModuleDefinition, which is just belowProgram. Any token with a Uri that is not part of the root set is considered to be included.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.