Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring the ability to test on local forks #3669

Closed

Conversation

davidcok
Copy link
Collaborator

@davidcok davidcok commented Mar 2, 2023

Being able to test on local forks (on a push event, without a PR having been created) saves CI resources and improves turnaround time on test failures. Note that it is not on by default -- only if the TEST_ON_FORK variable is set in the forked repo.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@davidcok davidcok requested a review from robin-aws March 2, 2023 20:18
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off let me apologize for removing the push trigger without spotting the additional logic designed to restrict that only to forks. I agree we should support running CI on forks easily somehow.

My typical workflow has been to create a dummy draft PR on my fork, based on my fork's copy of master (which I occasionally update when necessary). Once I have the PR cut every subsequent push triggers the CI, and I find it handy to browse the current set of changes in the PR anyway.

Would this workflow be acceptable instead of this solution? Part of the reason I prefer it is that it's much simpler to implement - we don't need all these extra if conditions everywhere.

@davidcok
Copy link
Collaborator Author

davidcok commented Mar 2, 2023

So with a draft PR:

  • we can run the CI locally?
  • and it does not run on master/main-* ?

@davidcok
Copy link
Collaborator Author

davidcok commented Mar 2, 2023

Draft PRs do have the disadvantage of spamming other people's email

@robin-aws
Copy link
Member

Draft PR on my fork though, so it won't spam anybody but me. :)

@davidcok
Copy link
Collaborator Author

Closing as abandoned

@davidcok davidcok closed this Mar 22, 2023
@davidcok davidcok deleted the cok-restoring-local-testing branch March 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants