Axiom warning refactoring #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-aws
reviewed
Mar 2, 2023
| // LHS failed to resolve. Abort trying to resolve assign or return stmt | ||
| return; | ||
| } else { | ||
| throw new InvalidOperationException("Internal error: unexpected option in ResolveAssignOrReturnStmt"); |
There was a problem hiding this comment.
Update error message: ResolveAssignOrReturnStmt doesn't exist anymore, I think.
stefan-aws
previously approved these changes
Mar 2, 2023
There was a problem hiding this comment.
A (potentially incomplete) summary of the changes:
- Moves
MethodfromMemberDecl.cstoMethod.cs - Moves
ConcreteUpdateStatementfromStatement.cstoConcreteUpdateStatement.cs - Moves
UpdateStmtfromStatement.cstoUpdateStmt.cs - Moves
ResolveUpdateStmtfromNameResolutionAndTypeInference.cstoResolveinUpdateStmt.cs - Moves
IteratorDeclfromTopLevelDeclarations.cstoIteratorDeclinIteratorDecl.cs - In
Resolver.csrefactors code as call to new functionsFillInPostConditionsAndBodiesOfPrefixLemmasinResolver.csandResolveinIteratorDecl.cs - Moves
CreateIteratorMethodSpecsfromResolver.cstoIteratorDecl.cs - Sort of moves
ResolveNestedMatchStmtfromResolver.cstoNestedMatchStmt.cs - Move
ResolveAssignOrReturnStmtfromResolver.cstoResolveinAssignOrReturnStmt.cs - Moves
ResolveMethodfromNameResolutionAndTypeInference.cstoResolveinMethod.cs - Moves
ResolveFunctionfromNameResolutionAndTypeInference.cstoResolveinFunction.cs - Moves
ResolveAssignSuchThatStmtinNameResolutionAndTypeInference.cstoResolveinAssignSuchThatStmt.cs - Moves
ConcreteUpdateStatementinStatement.cstoConcreteUpdateStatement.cs - Moves
UpdateStmtinStatement.cstoUpdateStmt.cs - Moves
ResolverfromResolver.cstoResolveinIteratorDecl.cs
stefan-aws
approved these changes
Mar 2, 2023
atomb
pushed a commit
to atomb/dafny
that referenced
this pull request
Mar 2, 2023
Refactoring part of dafny-lang#3553 No code has been changed, only moved. <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
robin-aws
added a commit
that referenced
this pull request
Mar 8, 2023
Updating `master` to pick up all `main-4.0`-specific changes (mostly switching default option values) The only two merge conflicts were: 1. `SinglePassCompiler.cs` - non-conflict between #3546 and #3647 touching adjacent lines. 2. `lit.sit.cfg` - slight conflict between #3662 improving the search for Z3 and 4.0 making it only search for 4.12.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring part of #3553
No code has been changed, only moved.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.