Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ide-vscode for blockers in release script #3604

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Check ide-vscode for blockers in release script #3604

merged 4 commits into from
Feb 22, 2023

Conversation

alex-chew
Copy link
Contributor

No description provided.

robin-aws
robin-aws reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Were you able to test it with a --dry-run?

@alex-chew
Copy link
Contributor Author

I've tested the _no_release_blocking_issues on its own in a shell, but a --dry-run won't work as written because the other checks won't pass (there's nothing in docs/dev/news, it's not on master, etc.).

@alex-chew alex-chew enabled auto-merge (squash) February 22, 2023 21:10
robin-aws
robin-aws approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alex-chew alex-chew merged commit 800b204 into master Feb 22, 2023
@alex-chew alex-chew deleted the check-ide-vscode-for-release-blockers branch February 22, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-aws robin-aws robin-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-chew @robin-aws