Test if this is a typo in prelude #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is an attempt at detecting if an axiom was wrongly instantiated. If all the CI test pass, then it's likely a typo fix and I'll follow up with a test to ensure #3411 is fixed
MikaelMayer
commented
Jan 26, 2023
RustanLeino
approved these changes
Jan 26, 2023
|
The reason why it was working before was because of this axiom axiom (forall t0: Ty,
t1: Ty,
heap: Heap,
h: [Heap,Box]Box,
r: [Heap,Box]bool,
rd: [Heap,Box]Set Box,
bx0: Box ::
{ Apply1(t0, t1, heap, Handle1(h, r, rd), bx0) }
Apply1(t0, t1, heap, Handle1(h, r, rd), bx0) == h[heap, bx0]);As you can see, |
atomb
pushed a commit
to atomb/dafny
that referenced
this pull request
Feb 1, 2023
This PR fixes dafny-lang#3411 Seems like one of Boogie's axiom was wrong, but it was unnoticed because another application axiom was ignoring the wrong argument. I added the test case of the issue. <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3411
Seems like one of Boogie's axiom was wrong, but it was unnoticed because another application axiom was ignoring the wrong argument.
I added the test case of the issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.