Try to treat general map comprehension as the common case #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a general map comprehension has the form `map x | R(x) :: x := T(x)`, then translate it (in the verifier) in the same way as the common `map x | R(x) :: T(x)`. Fixes dafny-lang#336
seanmcl
approved these changes
Aug 6, 2019
| @@ -10224,6 +10224,31 @@ public MapComprehension(IToken tok, bool finite, List<BoundVar> bvars, Expressio | |||
| TermLeft = termLeft; | |||
| } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Curious, what tool processes these xml tags?
There was a problem hiding this comment.
Could we have a comment why being a general map comprehension is significant? (Maybe just a copy of the detail of the PR, if that's the only significance.)
There was a problem hiding this comment.
These xml tags are used by the IDE (at least in Visual Studio, and I'm guessing also in Rider, but I haven't thought about it) to display hover text as information about the method.
The general map comprehensions were needed in some example where it was impossible to create the desired map with the simpler (and far more common) map comprehension. I think this is the example:
map x | x in S :: f(x) := g(x)
| // RUN: %dafny "%s" > "%t" | ||
| // RUN: %diff "%s.expect" "%t" | ||
|
|
||
| lemma TestMap(a: map<int, (int,int)>) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a general map comprehension has the form
map x | R(x) :: x := T(x), thentranslate it (in the verifier) in the same way as the common
map x | R(x) :: T(x).Fixes #336