Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Errors on refined modules displayed in refined modules, not abstracts ones #3330

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Fix: Errors on refined modules displayed in refined modules, not abstracts ones #3330

wants to merge 6 commits into from

Conversation

MikaelMayer
Copy link
Member

@MikaelMayer MikaelMayer commented Jan 5, 2023 •
edited
Loading

This PR fixes #3329

I had to fix several things for that. Here were the problems I fixed:

  • Refined declarations were using the same token as their abstract counterpart. This prevented gutter errors to be recorded at all for these declarations.
  • Refined tokens' filenames are the filename plus the [moduleName], which interfered with the ability of the gutter icons rendered to consider that refining modules were actually part of the file.

TODO: Need to fix errors and make everything consistent

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@MikaelMayer MikaelMayer marked this pull request as draft January 6, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module refinement breaks outline, error reporting and gutter icons
1 participant
@MikaelMayer