refactor: Move Resolver.{TypeSubstitutionMap, SubstType} #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
previously approved these changes
Nov 16, 2022
RustanLeino
changed the title
keyboardDrummer
approved these changes
Nov 23, 2022
| @@ -1183,6 +1183,9 @@ public abstract class ResolverType : Type { | |||
| public override bool ComputeMayInvolveReferences(ISet<DatatypeDecl>/*?*/ visitedDatatypes) { | |||
| return false; | |||
| } | |||
| public override Type Subst(Dictionary<TypeParameter, Type> subst) { | |||
| throw new NotImplementedException(); | |||
There was a problem hiding this comment.
I think NotSupportedException would be more accurate. NotImplementedException indicates there's work left to do.
There was a problem hiding this comment.
Good point. Since this PR was already auto-merged, I will incorporate this change in PR #3056, which had triggered this one.
| @@ -1749,6 +1754,10 @@ public abstract class ArtificialType : Type { | |||
| // ArtificialType's are used only with numeric types. | |||
| return false; | |||
| } | |||
|
|
|||
| public override Type Subst(Dictionary<TypeParameter, Type> subst) { | |||
| throw new NotImplementedException(); | |||
There was a problem hiding this comment.
I think NotSupportedException would be more accurate. NotImplementedException indicates there's work left to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just moves two type-related utility methods from
Resolver:Resolver.SubstType-> abstract instance methodType.SubstResolver.TypeSubstitutionMap->TypeParameter.SubstitutionMapBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.