feat: Make sure that dafny run always requests UTF-8 encoded output
#3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
force-pushed
the
cpitclaudel_dafny-run-utf-8
branch
2 times, most recently
from
4119777
to
cbc58b4
Compare
Closes #2999 (but beware of encoding issues in Go and C++).
cpitclaudel
force-pushed
the
cpitclaudel_dafny-run-utf-8
branch
from
cbc58b4
to
673731b
Compare
robin-aws
reviewed
Nov 15, 2022
Comment on lines
+1733
to
+1736
| (e.g. `-Dfile.encoding=` for Java). This is in fact how `dafny run` operates: | ||
| it uses language-specific flags and variables to enforce UTF-8 output regardless | ||
| of the target language (but note that the C++ and Go backends currently have | ||
| limited support for UTF-16 surrogates). |
There was a problem hiding this comment.
This is great but I feel it should also be in documentation specifically for the dafny run command and not just for the print statement. Perhaps http:https://dafny.org/dafny/DafnyRef/DafnyRef#256-using-dafny-from-the-command-line?
Well, not really; it's more that Go passes strings through without modification, so as long as we construct UTF-8 we're fine (which we do for since UTF-16 code units, but not for paired ones, hence the commented-out part of the test. |
robin-aws
reviewed
Nov 16, 2022
Co-authored-by: Robin Salkeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2999 (but beware of encoding issues in Go and C++).