feat: Consistent "create_<ctorname>" method for record types #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
added a commit
to smithy-lang/smithy-dafny
that referenced
this pull request
Feb 15, 2023
Where "srv's Op strucs" is a Service's Operation Structures, or all of a Service's Operations' Input, Output, Errors and all shapes related to the above. We need dafny-lang/dafny#3034 to resolve singular datatype creation (now known as a "Record Type"). DONE: - [x] Test Java KMS - [x] Test Java DDB - [x] Merge #83 into this TODO: - [ ] Test Java DDB again - [ ] Address Issues raised in PR #82, #92, #83
…ate-method-for-record-types # Conflicts: # Test/comp/Extern.dfy # Test/comp/Extern.dfy.expect # Test/comp/Extern4.go # Test/comp/Extern5.py
fabiomadge
approved these changes
Feb 21, 2023
texastony
added a commit
to smithy-lang/smithy-dafny
that referenced
this pull request
Mar 2, 2023
Where "srv's Op strucs" is a Service's Operation Structures, or all of a Service's Operations' Input, Output, Errors and all shapes related to the above. We need dafny-lang/dafny#3034 to resolve singular datatype creation (now known as a "Record Type"). DONE: - [x] Test Java KMS - [x] Test Java DDB - [x] Merge #83 into this TODO: - [ ] Test Java DDB again - [ ] Address Issues raised in PR #82, #92, #83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in C# and Java, compiled datatypes expose a
create_A(...)factory method for eachAdata constructor. However, datatypes with a single data constructor, also called "record types", will instead expose a singlecreatemethod. This is slightly nicer for hand-written external code, but creates an annoying special case for generated code.This change ensures that record types expose BOTH a
create_<ctorname>method for the single data constructor AND acreatemethod that thunks to it, to maintain backwards compatibility but also provide consistent naming.Added cases to test this to the existing
Extern.dfytest case, which now shows that at least all supported languages in that test case provide such consistently-named (within a language at least) factory methods, and don't require direct calls to constructors (note that Python has built-in support such that for a classFoo,Foo(...)can be redefined as needed, and so provides the same flexibility as a factory method).By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.