Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definiteAssignment option mapping to release notes #2948

Closed
wants to merge 3 commits into from

Conversation

keyboardDrummer
Copy link
Member

Fixes #

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer changed the title Add option mapping to release notes Add definiteAssignment option mapping to release notes Oct 31, 2022
@keyboardDrummer keyboardDrummer marked this pull request as ready for review October 31, 2022 13:51
Copy link
Member

@cpitclaudel cpitclaudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc change is fine, but I think we should hold off on it before we review what --enforce-determinism should really do; I've created a new issue at #2959

1 => false, false
2 => false, true
3 => true, true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might use bullet points or a code block or a table here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants