Fix: Variable declarations in match cases, formals do not trigger errors anymore #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors anymore This PR ensures that, in the case of branch duplication in resolution, exactly one branch reuses the same variables as the original branch (local variable declarations, formals, and bound variables in patterns). That way, we fix #2905 and moreover fix the previous issue that hovering other variables in match cases was not displaying type information
cpitclaudel
requested changes
Oct 21, 2022
…afny-lang/dafny into fix-2905-name-resolution-error
cpitclaudel
reviewed
Oct 24, 2022
cpitclaudel
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that, in the case of branch duplication in resolution, exactly one branch reuses the same variables as the original branch (local variable declarations, formals, and bound variables in patterns).
That way, we fix #2905 and moreover fix the previous issue that hovering other variables in match cases was not displaying type information
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.