-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Node CLI arguments for dafny to have the right order #2876
Conversation
This PR fixes #2867 I did not test it for languages other than C#, JavaScript and C++ because I am unsure for now of the procedure to launch the executable in the remaining languages (Go, Java, Python)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the quick fix! My only ask is to explicitly call this out as a fix:
release note. This could be considered a breaking change, but I think it's reasonable to say it was underspecified and this is clearly better behaviour.
I tried to spend some time to make it work for Java but it seems we don't have a standard procedure for launching programs, so I leave it unspecified for now.
That's fine for this PR, but FYI https://github.com/dafny-lang/dafny/blob/master/Test/comp/manualcompile/ManualCompile.dfy has the blueprint you're looking for. But I would also love to add support for command-line arguments to %testDafnyForEachCompiler
:)
… into fix-2867-node-cli
Oh thanks, I did not know about this file ! That was very helpful. |
docs/dev/news/2876.fix
Outdated
@@ -0,0 +1 @@ | |||
Same argument order for stand-alone javascript files than for other languages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
than => as
I addressed all the points of @robin's review and got another approval.
Can we refine the release notes for this? It's hard to understand what this means without context (and reading the PR description doesn't help too much either) |
This PR fixes #2867
Tests for C#, JavaScript and C++
I tried to spend some time to make it work for Java but it seems we don't have a standard procedure for launching programs, so I leave it unspecified for now.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.