Fix: Compiled lambdas now close only on non-ghost variables #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the problem that lambdas were closing over ghost variables in compiled code, resulting at best in compilation errors (in C#), at worst in a soundness issue crash at run-time (in js). As you can see, the fix is very small. I added an integration test to ensure this behavior is correctly captured.
keyboardDrummer
previously approved these changes
Oct 5, 2022
cpitclaudel
previously approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Looks good to me. Could you check if this PR also fixes bug #2690 ? If so, it would be good to copy the test from there (and if not, it would be good to add a note to that issue)
…om/dafny-lang/dafny into fix-2852-soundness-compiler-lambda
cpitclaudel
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that lambdas were closing over ghost variables in compiled code, resulting at best in compilation errors (in C#), at worst in a soundness issue crash at run-time (in js). As you can see, the fix is very small. I added an integration test to ensure this behavior is correctly captured.
Fixes #2852
Fixes #2690
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.