Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Formatted every test file with the formatter #2714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MikaelMayer
Copy link
Member

@MikaelMayer MikaelMayer commented Sep 8, 2022

This PR used the formatter being developed in #2399 to format all the test files

We can use it as a baseline to discuss formatting points. For example

  1. In the case above, it's implemented using the second case. Do we want the first case to also be valid? Or should the first case always be the right case?
...
else if X then
  Y
// This comment about Z
else if Z then
  ...
...
else if X then
  Y
  // Unlikely comment about Y but it's the trailing trivia anyway.
else if Z then
  ...

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants