Fix: No crash anymore on the IDE when using the elephant operator #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2667 by remarking that sometimes, Tok is before EndTok for an obscure reason. In the case of the elephant operator in `var x :- Parse()`, Tok designates `:-` and EndTok designates `x`, probably because the declaration is the same as the update. I fixed the generation of faulty rangeToken like this for all statements. Tested in the language server tests directly.
keyboardDrummer
previously approved these changes
Aug 31, 2022
keyboardDrummer
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2667 by remarking that sometimes, Tok is before EndTok for an obscure reason.
In the case of the elephant operator in
var x :- Parse(), Tok designates:-and EndTok designatesx, probably because the declaration is the same as the update.I fixed the generation of faulty rangeToken like this for all statements.
Tested in the language server tests directly.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.