fix: Missing related position in failing precondition #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2657 by adding a token in a generated boogie expression.
RustanLeino
reviewed
Aug 31, 2022
Comment on lines
-1885
to
+1887
| return Boogie.Expr.Gt(Boogie.Expr.SelectTok(tok, TrExpr(s), elmtBox), Boogie.Expr.Literal(0)); | ||
| var result = Boogie.Expr.Gt(Boogie.Expr.SelectTok(tok, TrExpr(s), elmtBox), Boogie.Expr.Literal(0)); | ||
| result.tok = tok; | ||
| return result; |
There was a problem hiding this comment.
This seems like it may be wrong for all calls into Boogie.Expr..... A possibility would be to fix all of them by changing line 172 of $Boogie/Source/Core/AbsyExpr.cs to replace Token.NoToken with e0.tok.
RustanLeino
previously approved these changes
Aug 31, 2022
RustanLeino
previously approved these changes
Sep 1, 2022
RustanLeino
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2657 by adding a token in a generated boogie expression.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.