fix: "Failing precondition" on tooltip instead of "return path" #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2653. Also made the tests more robust by removing the need of Task.Delay
MikaelMayer
commented
Aug 29, 2022
| @@ -229,6 +242,9 @@ method Abs(x: int) returns (y: int) | |||
| await client.OpenDocumentAndWaitAsync(documentItem, CancellationToken); | |||
| var lastStatus = await WaitUntilDafnyFinishes(documentItem); | |||
| Assert.AreEqual(expectedStatus, lastStatus); | |||
| foreach (var document in Documents.Documents) { | |||
| await document.LastDocument; | |||
There was a problem hiding this comment.
@keyboardDrummer do your confirm it's the right way to wait for the final translated and verified document to be available?
There was a problem hiding this comment.
If verification has been triggered, like through verification on change or manual verification, this will wait for verification to complete. If verification has not been triggered, this returns after translation.
There was a problem hiding this comment.
Great, that's what I wanted to know.
keyboardDrummer
previously approved these changes
Aug 30, 2022
keyboardDrummer
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2653.
Also made the tests more robust by removing the need of Task.Delay
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.