Implemented a warning to prevent varaibles and constructors from having the same name #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12800,6 +12800,10 @@ private class ClonerKeepLocalVariablesIfTypeNotSet : Cloner { | |||
| // Check if the head of the pattern is a constructor or a variable | |||
| if (ctors.TryGetValue(idpat.Id, out ctor)) { | |||
| /* =[3]= */ | |||
| if (ctor != null && idpat.Arguments == null && ctor.Formals.Count != 0) { | |||
There was a problem hiding this comment.
The condition of this if and the next one are quite similar. Consider combining the two:
if (ctor != null && idpat.Arguments == null) {
if (ctor.Formals.Count == 0) {
// nullary constructor without () -- so convert it to a constructor
idpat.MakeAConstructor();
}
else {
this.reporter.Warning(MessageSource.Resolver, pat.Tok,
$"Variable name '{pat}' has the same name as a datatype constructor that's in scope at this location");
}
}
keyboardDrummer
previously approved these changes
Aug 15, 2022
|
Looks great! I left one refactoring comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.