feat: Don't force :extern members to be implemented in derived classes #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
force-pushed
the
cpitclaudel_extern-in-trait-2212
branch
from
2981e9e
to
56f7650
Compare
cpitclaudel
force-pushed
the
cpitclaudel_extern-in-trait-2212
branch
from
56f7650
to
35f3c88
Compare
fabiomadge
previously approved these changes
Jul 21, 2022
Comment on lines
+9389
to
+9390
| // Extern functions do not need to be reimplemented. | ||
| // TODO: When `:extern` is separated from `:compile false`, this should become `:compile false`. |
There was a problem hiding this comment.
Should we add this to the SinglePassCompiler as well?
Co-authored-by: Fabio Madge <[email protected]>
Co-authored-by: Fabio Madge <[email protected]>
fabiomadge
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2212.