fix: Correctly infer type of numeric arguments when the type is a subset type of a newtype #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
previously approved these changes
Jun 29, 2022
Source/Dafny/AST/DafnyAst.cs
Outdated
| @@ -2061,14 +2060,12 @@ public enum AutoInitInfo { MaybeEmpty, Nonempty, CompilableValue } | |||
|
|
|||
| var joinNeedsNonNullConstraint = false; | |||
| Type j; | |||
| if (a is UserDefinedType && ((UserDefinedType)a).ResolvedClass is NonNullTypeDecl) { | |||
| if ((a as UserDefinedType)?.ResolvedClass is NonNullTypeDecl aClass) { | |||
There was a problem hiding this comment.
Suggested change
| if ((a as UserDefinedType)?.ResolvedClass is NonNullTypeDecl aClass) { | |
| if (a is UserDefinedType { ResolvedClass: NonNullTypeDecl aClass }) { |
Source/Dafny/AST/DafnyAst.cs
Outdated
Comment on lines
2146
to
2148
| } else if (a.IsNumericBased()) { | ||
| return a.Equals(b) ? a : null; | ||
| } else if (a.IsBitVectorType) { |
There was a problem hiding this comment.
Could you fold these two cases in the one above?
cpitclaudel
previously approved these changes
Jun 29, 2022
cpitclaudel
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2307
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.