Update BigRational to be compatible with .NET 2.1
#2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
previously approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Tested and this LGTM.
I would seek another +1,
maybe @fabiomadge could help us :)
|
I think we'll do a separate PR to thoroughly test minimum language version requirements for compiled code in all the supported target languages. See #1983. |
fabiomadge
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2276
Existing tests should provide good evidence for the functional correctness of this fix. Testing for compatibility with .NET Standard 2.1 should exist, as well, but could arguably come as part of a separate PR that adds similar compatibility tests for the other runtime libraries.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.