Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct type for let expression generated by datatype update #2059

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

cpitclaudel
Copy link
Member

Closes GH-1479.

Co-authored-by: @RustanLeino

@cpitclaudel cpitclaudel force-pushed the cpitclaudel_fix-1479-datatype-update branch from 9901417 to 8784786 Compare April 25, 2022 20:40
@cpitclaudel cpitclaudel force-pushed the cpitclaudel_fix-1479-datatype-update branch from 8784786 to a46dbd0 Compare April 25, 2022 21:43
@cpitclaudel cpitclaudel added the logic An inconsistency in Dafny's logic (e.g. in the Boogie prelude) label Apr 25, 2022
@cpitclaudel cpitclaudel self-assigned this Apr 26, 2022
Test/git-issues/git-issue-1479a.dfy Outdated Show resolved Hide resolved
Test/git-issues/git-issue-1479b.dfy Outdated Show resolved Hide resolved
// RUN: %dafny /compile:0 "%s" > "%t"
// RUN: %diff "%s.expect" "%t"

type T
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to have the two test files, git-issue-1479a.dfy and git-issue-1479b.dfy, but if (for this PR or some future PRs) you want to combine them into one file and there are name clashes, then you can put each example in a separate module in the one test file.

@cpitclaudel cpitclaudel force-pushed the cpitclaudel_fix-1479-datatype-update branch from c6fe334 to 18b48ba Compare April 27, 2022 23:19
@cpitclaudel cpitclaudel force-pushed the cpitclaudel_fix-1479-datatype-update branch from 18b48ba to b704560 Compare April 27, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logic An inconsistency in Dafny's logic (e.g. in the Boogie prelude)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soundness: subtype predicate not checked on update of value taken from map
2 participants