fix: Substitute for receiver in automatically generated induction hypothesis #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `InstanceAboutUU()` would verify! :O
# Conflicts: # RELEASE_NOTES.md
fabiomadge
requested changes
Apr 11, 2022
| @@ -594,7 +594,7 @@ public partial class Translator { | |||
| // Generate a CallStmt for the recursive call | |||
| Expression recursiveCallReceiver; | |||
| List<Expression> recursiveCallArgs; | |||
| RecursiveCallParameters(m.tok, m, m.TypeArgs, m.Ins, substMap, out recursiveCallReceiver, out recursiveCallArgs); | |||
| RecursiveCallParameters(m.tok, m, m.TypeArgs, m.Ins, receiverSubst, substMap, out recursiveCallReceiver, out recursiveCallArgs); | |||
There was a problem hiding this comment.
Is the comment in L555 still up-to-date?
There was a problem hiding this comment.
I improved it.
Co-authored-by: Fabio Madge <[email protected]>
# Conflicts: # RELEASE_NOTES.md
fabiomadge
reviewed
Apr 12, 2022
fabiomadge
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lemma like
should give rise to an induction hypothesis (which is provided by the verifier as an assumption on entry to the lemma's body) of the form
Previously, this was generated incorrectly. In particular, the formula
this'.Post(x')was previously generated asthis.P(x'). This PR corrects the generated formula.Fixes #2001
The example given in issue #2001 is included in
Test/dafny1/Induction.dfy.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.