fix: Make verifier understand (!new) #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustanLeino
added a commit
to RustanLeino/dafny
that referenced
this pull request
Mar 26, 2022
Note that some tests are commented out, awaiting dafny-lang#1935 to be merged.
cpitclaudel
reviewed
Apr 1, 2022
# Conflicts: # RELEASE_NOTES.md
cpitclaudel
previously approved these changes
Apr 11, 2022
cpitclaudel
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the verifier understand that a type marked with
(!new)is considered allocated in any state.Notes:
iterator, in the case when the type of such an in-parameter was not an auto-init type.One new test case is commented out, because it currently does not go through due to a bug in Boogie: Prune prunes too much boogie-org/boogie#559. Once that bug is fixed, the line should be uncommented. I have tested that the behavior is correct without Boogie'sApparently, the problem lay with the present PR, which didn't set up the Boogie/pruneflag (which Dafny sets to be on).usesdependencies appropriate. That has now been fixed in the present PR.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.