Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Completed (and corrected) IteratorSpec section #1842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: Completed (and corrected) IteratorSpec section #1842

wants to merge 2 commits into from

Conversation

robin-aws
Copy link
Member

No description provided.

RustanLeino
RustanLeino requested changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@RustanLeino RustanLeino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also describing _new (including the fact that an iterator body can remove objects from _new) and the x/xs pun in specifications? Maybe showing one small example that uses these would do the trick.

docs/DafnyRef/Specifications.md
Comment on lines +534 to +535
that is used as a pre-condition for `MoveNext`. An iterator is only
guaranteed to be `Valid()` after invoking `MoveNext` if that method
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving the "only" to just before the "if"

@davidcok davidcok self-assigned this Jul 15, 2022
@davidcok davidcok assigned robin-aws and unassigned davidcok Jul 25, 2022
@davidcok davidcok self-requested a review July 25, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RustanLeino RustanLeino RustanLeino requested changes

@davidcok davidcok Awaiting requested review from davidcok

Requested changes must be addressed to merge this pull request.

Assignees

@robin-aws robin-aws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robin-aws @RustanLeino @davidcok