Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move banner back to the top of the page #1833

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

robin-aws
Copy link
Member

@robin-aws robin-aws commented Feb 16, 2022

Didn't notice this when reviewing #1575 :)

cpitclaudel
cpitclaudel previously approved these changes Feb 17, 2022
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that the "banner" is misplaced. One caveat though.
Moving the banner it to the bottom was not an error. A video is worth 1000 images, and the GIF aimed at giving a better view of what the Dafny experience looks like.

More than 50% of the "banner" contains a screenshot of Dafny in emacs mode, with mathematical operators that we know now frighten some developers ("how do I input this!?").
My take on that is that I would still like to keep the emacs screenshot, but it would be better at the bottom (not in the very first few moments someone new views when searching for Dafny), and with a proper documentation (This is Dafny in emacs mode, with mathematical operators).

I would also accept to just put the Dafny logo at the top, but not the screenshot, as it would start to give away some information that is not relevant on the very first few moments people want to spend with Dafny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants