Inline let-expressions before collecting quantifiers for trigger selection #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let expressions make some invalid triggers appear to be valid, so we should inline them before collecting the quantifiers from their bodies. Fixes dafny-lang#167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let expressions can change trigger selections in undesirable ways. For example, this expression:
has
n in pselected as a trigger, but if we manually inlinepthere is no trigger found.n in pisn't a valid trigger here, sincepwill get inlined into the trigger later.To fix this, we (temporarily) inline all lets before collecting the set of quantifiers to select triggers for. In some sense this is the converse of #130 -- here we inline lets appearing outside a quantifier.
Fixes #167.