Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for quantifiers + let-such-that expressions #170

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

jamesbornholt
Copy link
Collaborator

Fix two bugs involving combining let-such-thats with quantifiers:

  • When inlining lets during trigger selection, we need to check the let is exact (i.e., not a let-such that)
  • After fixing that issue, a let-such-that within a quantifier generates invalid Boogie, because let desugaring reuses a (mutable) substitution map that has had the quantified variables removed

LetExprs can only be inlined if they are exact (i.e., not let-such-that
expressions)
SubstLetExpr needs to keep a copy of the substMap, since it is mutable
and has bound variables removed from it after substitution.
@RustanLeino RustanLeino merged commit 0ef0bb6 into dafny-lang:master Feb 1, 2018
@jamesbornholt jamesbornholt deleted the quantfixes branch February 1, 2018 18:35
@keyboardDrummer keyboardDrummer self-assigned this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants