No independent consistency hiding #1474
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 30, 2021 11:19
robin-aws
pushed a commit
that referenced
this pull request
Oct 1, 2021
### Changes - Use predecessor count instead of topological order index, to determine the `FunctionContextHeight` of a SCC of callables. A node's predecessor count only changes when something related to the node is changed, while topological order index can change due to any change in the graph. ### Testing - Add a test that verifies that when concatenating two unrelated Dafny programs and compiling that to Boogie, no lines of Boogie are created that aren't created from the individual programs. - One test, `FunctionSpecifications`, was split into two to avoid a problem causing by inconsistencies hiding other errors. We wish to address this problem [this other PR](#1474) but it requires some Boogie changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: improve pruning in Boogie so things like
LitIntwon't stop the pruning.