-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bv synonyms #1406
base: master
Are you sure you want to change the base?
Bv synonyms #1406
Conversation
Co-authored-by: Rustan Leino <[email protected]>
Co-authored-by: Rustan Leino <[email protected]>
Co-authored-by: Rustan Leino <[email protected]>
Co-authored-by: Rustan Leino <[email protected]>
@RustanLeino, I couldn't figure out some of the code formatting errors. It looks like a recent change? |
You can run |
That works! Thanks |
@RustanLeino, can you take a look and merge ;p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I have but one comment: Please make the flag /useBvSynonyms
take an argument (like 0
or 1
). This will make it easier for us to change the default of this option in the future, without breaking anyone using the switch already.
I updated the flag to take a 0/1 argument. @RustanLeino, @keyboardDrummer, the failing case is a SegFault during build. Can you take a look? |
Not sure what causes those. Restarted the build. |
feat:
/useBvSynonyms
flag to use bv synonyms. Instead of defining bit vector operations directly as Z3 builtins, I add a dafny level function with an axiom saying that it is equal to the builtin. Just like multiplication.I've also inserted
split_here
assertions to make one of the tests go through faster.Future Work: Allow synonyms and builtins to be used at a finer granularity, i.e., let the programmer control for each method/function, whether or not the synonyms are used.