Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expand stdin.dfy as a path #1110

Closed
wants to merge 3 commits into from
Closed

Conversation

jaylorch
Copy link
Collaborator

@jaylorch jaylorch commented Feb 6, 2021

Fixes #1109

Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I wasn't even aware this was possible before! :) For the record I'm definitely not a fan of using such a magic file name, and would prefer an explicit switch like /stdin instead. Assuming this broke between 2.3 and 3.0, now would be the time to fix that since the major version bump allows the breaking change.

Regardless of what we decide there, we also badly need a regression test for this.

@davidcok
Copy link
Collaborator

davidcok commented Feb 6, 2021 via email

@robin-aws
Copy link
Member

I almost suggested - as well. I slightly prefer the switch since it's more "portable": - is more of a *nix system convention AFAIK, and I imagine it would feel a little strange on Windows.

@davidcok
Copy link
Collaborator

davidcok commented Feb 6, 2021 via email

@jaylorch
Copy link
Collaborator Author

jaylorch commented Feb 6, 2021

I agree that the magic name stdin.dfy is a bit weird as the way to do read from stdin. I wasn't even aware of this Dafny feature until, when I was updating rise4fun.com/dafny to use Dafny 3.0.0, I discovered it relied on it. And I definitely agree that a regression test is needed.

@jaylorch jaylorch closed this Feb 18, 2021
@jaylorch
Copy link
Collaborator Author

I want to use a different branch for this, so I'm closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdin.dfy doesn't work
4 participants