Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WIFI widget & fixed weather #106

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

wiki-Bird
Copy link
Contributor

Pull Request - #105 & #103

Description

I updated the config.yaml "last updated" information to reflect my updates.

Wifi Widget:

I added a new core "wifi' widget to widgets and validation. The widget uses os to get the user's signal strength, then displays said strength in the status bar using nerdfont icons (see image for icons)
strength icons used
On left click, the widget also displays the network name. It should be trivial to configure this to display other info, such as current upload/download rate. On right click, the widget opens Windows' network settings.

Weather Widget:

I implemented @zombie-bear's fix, using wttr.in instead of openweathermap.org. I, like zombie-bear, could not get openweathermap to function (possible due to API changes?), but after changing the API request to wttr.in had it working in seconds. I updated the default weather JSON paths to match the old content (temp in C, current condition), as well as the commented explanation in config.yaml.

Related Issues

Testing

OS: Windows 10 Pro
Komorebi: Yes
Python: 3.11.4
Terminal: Windows PowerShell in Windows Terminal

  • I ran the updated status bar on two computers in the default configuration (note that the missing icons are due to the default configuation using a nerdfont I don't have installed. This is already the case by default).
    default configuration

  • I linted the code using pylama (note that all errors seen in the image exist on the current yasb main branch, none of the added code is flagged).
    pylama linting

  • I ran my custom theme with the new widget
    custom configuration

  • I changed the config.yaml default options for wifi (eg: icons, update interval)

  • I tried multiple cities using wttr.in and verified the weather against local conditions

All of these performed as expected.

@da-rth
Copy link
Owner

da-rth commented Sep 19, 2023

I haven't really been maintaining the python version of yasb as of recent, but this contribution looks great. The changes look pretty good so I'm happy to merge this in.

Thank you for your contribution

@da-rth da-rth merged commit e10b786 into da-rth:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants