Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not invert token.Less to token.Greater in compiler #391

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix: do not invert token.Less to token.Greater in compiler #391

merged 2 commits into from
Aug 29, 2022

Conversation

shiyuge
Copy link
Contributor

@shiyuge shiyuge commented Aug 12, 2022 •
edited
Loading

I have posted an issue explaining this #390

@shiyuge shiyuge mentioned this pull request Aug 12, 2022
Closed
@shiyuge shiyuge changed the title fix: do not invert token.Less to token.Great in compiler fix: do not invert token.Less to token.Greater in compiler Aug 12, 2022
geseq
geseq reviewed Aug 28, 2022
View reviewed changes
Copy link
Collaborator

@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Overall LGTM but can you please add a test similar to one you described in your issue for future regression testing?

@shiyuge
Copy link
Contributor Author

shiyuge commented Aug 29, 2022

Thanks for the reply. A new test case is added

@shiyuge shiyuge requested a review from geseq August 29, 2022 08:54
@geseq geseq merged commit e338512 into d5:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geseq geseq geseq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiyuge @geseq