Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GPN card #90

Merged
merged 1 commit into from
Oct 1, 2022
Merged

feat: add GPN card #90

merged 1 commit into from
Oct 1, 2022

Conversation

blouflashdb
Copy link
Contributor

Closes #89

@aloisdg aloisdg added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest encourages participation in the open source community, which grows bigger every year. hacktoberfest-accepted labels Sep 26, 2022
aloisdg
aloisdg approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@aloisdg aloisdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@aloisdg
Copy link
Member

aloisdg commented Sep 27, 2022

@blouflashdb Hacktoberfest has not yet begun, should I hold off on this pull requests until October so they can count or should I merge it right away?

torendil
torendil approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@torendil torendil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM too :)

@blouflashdb
Copy link
Contributor Author

blouflashdb commented Sep 27, 2022 •
edited

@blouflashdb Hacktoberfest has not yet begun, should I hold off on this pull requests until October so they can count or should I merge it right away?

Hold it off.

@aloisdg
Copy link
Member

aloisdg commented Sep 27, 2022

No problem we will do that. Thanks again for your contribution :)

@aloisdg aloisdg merged commit 81cd3f6 into d-edge:main Oct 1, 2022
@aloisdg
Copy link
Member

aloisdg commented Oct 1, 2022

Merged! It should be visible in the website:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torendil torendil torendil approved these changes

@aloisdg aloisdg aloisdg approved these changes

@fighou fighou Awaiting requested review from fighou

@4gq 4gq Awaiting requested review from 4gq

@ytyukhnin ytyukhnin Awaiting requested review from ytyukhnin

Assignees

@blouflashdb blouflashdb

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest encourages participation in the open source community, which grows bigger every year. hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for card GPN
3 participants
@blouflashdb @aloisdg @torendil