Use new PWS access API #138
Conversation
In previous versions of nitrokey-rs, the getters for the name, login and password fields of a PWS slot would return an error for empty strings as libnitrokey uses empty strings to indicate unprogrammed slots. But as the user might have deliberately specified an empty value, nitrokey-rs v0.9.0 introduces a new PWS API that makes it possible to distinguish unprogrammed slots and empty values. This patch updates the nitrokey-rs dependency and refactors the pws status and pws get commands to use the new PWS API.
|
@d-e-s-o Could you please review the changes? If you don’t have any objections, I’ll release a new nitrokey-rs version soon and then convert this draft into a PR. |
|
Thanks for the pull request, Robin! I'll take a closer look hopefully tomorrow morning and will hopefully have an answer to your question by then. |
| let slots = pws | ||
| .get_slot_status() | ||
| .context("Failed to read PWS slot status")?; | ||
| let slots = pws.get_slots().context("Failed to read PWS slot status")?; |
There was a problem hiding this comment.
Consider adjusting the error message slightly to "Failed to read PWS slots".
There was a problem hiding this comment.
I’m not sure about that. Internally, we still call the GET_PW_SAFE_SLOT_STATUS command. “Failed to read PWS slots” sounds as if we tried to read the slot values.
|
Thanks for the review! I’ve released nitrokey-rs v0.9.0 and updated the PR. |
|
I merged the change into |
In previous versions of nitrokey-rs, the getters for the name, login and
password fields of a PWS slot would return an error for empty strings as
libnitrokey uses empty strings to indicate unprogrammed slots. But as
the user might have deliberately specified an empty value, nitrokey-rs
v0.9.0 introduces a new PWS API that makes it possible to distinguish
unprogrammed slots and empty values.
This patch updates the nitrokey-rs dependency and refactors the pws
status and pws get commands to use the new PWS API.
Fixes #133.
To discuss: