Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List libnitrokey version #147

Closed
robinkrahl opened this issue Apr 13, 2021 · 2 comments
Closed

List libnitrokey version #147

robinkrahl opened this issue Apr 13, 2021 · 2 comments

Comments

@robinkrahl
Copy link
Collaborator

Knowing the libnitrokey version used by nitrocli is an important information for debugging. Currently, it is impossible to determine the library version unless nitrocli is linked against a shard libnitrokey. We should probably have a version command that lists both the nitrocli version and the libnitrokey version as returned by nitrokey::get_library_version().
@d-e-s-o
Copy link
Owner

d-e-s-o commented Apr 13, 2021

I agree, but can we just include that in the -V/--version output please? I don't see the point in having a dedicated command for that.

robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Apr 13, 2021
@robinkrahl
Add libnitrokey version to -V/--version output
042c061 
Currently, it is hard to determine the libnitrokey version used by
nitrocli unless it is linked against a shard library.  This patch adds
the libnitrokey version (nitrokey::get_library_version()) to the
-V/--version output.

Fixes d-e-s-o#147.
@robinkrahl robinkrahl mentioned this issue Apr 13, 2021
Closed
@robinkrahl
Copy link
Collaborator Author

Good point! I missed that because it didn’t turn up in grep version -r src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add libnitrokey version to -V/--version output robinkrahl/nitrocli
2 participants
@robinkrahl @d-e-s-o