Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow spaces in OTP base32 secret #136

Closed
robinkrahl opened this issue Feb 14, 2021 · 2 comments
Closed

Allow spaces in OTP base32 secret #136

robinkrahl opened this issue Feb 14, 2021 · 2 comments
Assignees
@robinkrahl

Comments

@robinkrahl
Copy link
Collaborator

Some sites display the base32 secret for OTP authentication in groups, separated by spaces. nitrocli should be able to handle such input without requiring the user to manually remove the spaces.
@d-e-s-o
Copy link
Owner

d-e-s-o commented Feb 15, 2021

Can you provide an example please? I am not sure I fully understand what groups you are referring to.

@robinkrahl
Copy link
Collaborator Author

robinkrahl commented Feb 15, 2021 via email

@robinkrahl robinkrahl self-assigned this Apr 9, 2021
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Apr 9, 2021
@robinkrahl
Allow spaces in base32 OTP secrets
f370e7d 
Some sites as GitLab display their OTP secrets as base32 strings in
groups separated by spaces.  Previously, the user had to manually remove
the spaces before passing the secret to nitrocli.  But as the space can
never be part of the base32 string itself, we can unambigously identify
it as a separator and remove it from the secret before processing it.

Fixes d-e-s-o#136.
@robinkrahl robinkrahl mentioned this issue Apr 9, 2021
Closed
d-e-s-o pushed a commit that referenced this issue Apr 10, 2021
@robinkrahl @d-e-s-o
Allow spaces in base32 OTP secrets
3a12546 
Some sites, such as GitLab, display their OTP secrets as base32 strings
in groups separated by spaces.  Previously, the user had to manually
remove the spaces before passing the secret to nitrocli.  But as the
space can never be part of the base32 string itself, we can
unambiguously identify it as a separator and remove it from the secret
before processing it.

Fixes #136
@d-e-s-o d-e-s-o closed this as completed Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinkrahl robinkrahl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robinkrahl @d-e-s-o