Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check frames for NULL when sending data from the renderer process using IPC #431

Closed
cztomczak opened this issue May 23, 2018 · 1 comment
Labels
Milestone

Comments

@cztomczak
Copy link
Owner

In ClientHandler::OnProcessMessageReceived any frame IDs sent as ints and then converted back into CefFrame objects need to be checked for NULL, as these frames may already be destroyed in some cases. Callbacks in the browser process like V8ContextHandler_OnContextCreated shall not be called if frame is NULL (destroyed).

Code should be analyzed whether disabling such calls won't have any side effects. Check all functions that are currently called with NULL frames. See:

bool ClientHandler::OnProcessMessageReceived(

Issue initially commented here:
jakogut@016f77d

Topic on the CEF forum:
https://magpcss.org/ceforum/viewtopic.php?f=6&t=16007

@cztomczak cztomczak added this to the v66 milestone May 23, 2018
cztomczak added a commit that referenced this issue Aug 17, 2018
Remove Python callback references properly.

Fix PyCharm code inspection warnings in main_test.py.
@cztomczak
Copy link
Owner Author

Fixed in commit a010e68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant